nbd/server: Fix drained_poll to wake coroutine in right AioContext
commit7c1f51bf38de8cea4ed5030467646c37b46edeb7
authorKevin Wolf <kwolf@redhat.com>
Wed, 17 May 2023 15:28:33 +0000 (17 17:28 +0200)
committerKevin Wolf <kwolf@redhat.com>
Fri, 19 May 2023 17:16:53 +0000 (19 19:16 +0200)
tree0a1fb3424e3310217287f102b397d50ee2617f4b
parent80fc5d260002432628710f8b0c7cfc7d9b97bb9d
nbd/server: Fix drained_poll to wake coroutine in right AioContext

nbd_drained_poll() generally runs in the main thread, not whatever
iothread the NBD server coroutine is meant to run in, so it can't
directly reenter the coroutines to wake them up.

The code seems to have the right intention, it specifies the correct
AioContext when it calls qemu_aio_coroutine_enter(). However, this
functions doesn't schedule the coroutine to run in that AioContext, but
it assumes it is already called in the home thread of the AioContext.

To fix this, add a new thread-safe qio_channel_wake_read() that can be
called in the main thread to wake up the coroutine in its AioContext,
and use this in nbd_drained_poll().

Cc: qemu-stable@nongnu.org
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Message-Id: <20230517152834.277483-3-kwolf@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
include/io/channel.h
io/channel.c
nbd/server.c