| commit | 7b99fb30b39bb14733aa3645b68e0103bbf8e43a | |
| author | Glenn Miles <milesg@linux.vnet.ibm.com> | |
| Thu, 25 Jan 2024 22:48:10 +0000 (25 16:48 -0600) | ||
| committer | Nicholas Piggin <npiggin@gmail.com> | |
| Fri, 23 Feb 2024 13:24:42 +0000 (23 23:24 +1000) | ||
| tree | 25b933617d14ece8600951bc6d92293aa234b2c5 | treesnapshot (tar.gz zip) |
| parent | 21465ade7ffdc569e5a29bb604dd27a1d36b60b4 | commitdiff |
misc/pca9552: Fix inverted input status
The pca9552 INPUT0 and INPUT1 registers are supposed to
hold the logical values of the LED pins. A logical 0
should be seen in the INPUT0/1 registers for a pin when
its corresponding LSn bits are set to 0, which is also
the state needed for turning on an LED in a typical
usage scenario. Existing code was doing the opposite
and setting INPUT0/1 bit to a 1 when the LSn bit was
set to 0, so this commit fixes that.
Reviewed-by: Andrew Jeffery <andrew@codeconstruct.com.au>
Signed-off-by: Glenn Miles <milesg@linux.vnet.ibm.com>
Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
The pca9552 INPUT0 and INPUT1 registers are supposed to
hold the logical values of the LED pins. A logical 0
should be seen in the INPUT0/1 registers for a pin when
its corresponding LSn bits are set to 0, which is also
the state needed for turning on an LED in a typical
usage scenario. Existing code was doing the opposite
and setting INPUT0/1 bit to a 1 when the LSn bit was
set to 0, so this commit fixes that.
Reviewed-by: Andrew Jeffery <andrew@codeconstruct.com.au>
Signed-off-by: Glenn Miles <milesg@linux.vnet.ibm.com>
Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
| hw/misc/pca9552.c | diffblobblamehistory | |
| tests/qtest/pca9552-test.c | diffblobblamehistory |