| commit | 74e2e59b8d0a68be0956310fc349179c89fd7be0 | |
| author | Peter Maydell <peter.maydell@linaro.org> | |
| Mon, 8 Oct 2018 13:55:05 +0000 (8 14:55 +0100) | ||
| committer | Peter Maydell <peter.maydell@linaro.org> | |
| Mon, 8 Oct 2018 13:55:05 +0000 (8 14:55 +0100) | ||
| tree | 2a3929c352b68589d0ee5d3b36573d93d9ae707e | treesnapshot (tar.gz zip) |
| parent | 167765f0739e4a108e8c2e2ff2f37917df5658f9 | commitdiff |
hw/display/bcm2835_fb: Silence Coverity warning about multiply overflow
Coverity complains (CID 1395628) that the multiply in the calculation
of the framebuffer base is performed as 32x32 but then used in a
context that takes a 64-bit hwaddr. This can't actually ever
overflow the 32-bit result, because of the constraints placed on
the s->config values in bcm2835_fb_validate_config(). But we
can placate Coverity anyway, by explicitly casting one of the
inputs to a hwaddr, so the whole expression is calculated with
64-bit arithmetic.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-id: 20181005133012.26490-1-peter.maydell@linaro.org
Coverity complains (CID 1395628) that the multiply in the calculation
of the framebuffer base is performed as 32x32 but then used in a
context that takes a 64-bit hwaddr. This can't actually ever
overflow the 32-bit result, because of the constraints placed on
the s->config values in bcm2835_fb_validate_config(). But we
can placate Coverity anyway, by explicitly casting one of the
inputs to a hwaddr, so the whole expression is calculated with
64-bit arithmetic.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-id: 20181005133012.26490-1-peter.maydell@linaro.org
| hw/display/bcm2835_fb.c | diffblobblamehistory |