| commit | 72f0d0bf51362011c4d841a89fb8f5cfb16e0bf3 | |
| author | Greg Kurz <groug@kaod.org> | |
| Sun, 26 Feb 2017 22:42:51 +0000 (26 23:42 +0100) | ||
| committer | Greg Kurz <groug@kaod.org> | |
| Tue, 28 Feb 2017 10:21:15 +0000 (28 11:21 +0100) | ||
| tree | f331ff1b1b177f6273edb2f989c3f95159c41e39 | treesnapshot (tar.gz zip) |
| parent | 3e36aba757f76673007a80b3cd56a4062c2e3462 | commitdiff |
9pfs: local: lremovexattr: don't follow symlinks
The local_lremovexattr() callback is vulnerable to symlink attacks because
it calls lremovexattr() which follows symbolic links in all path elements
but the rightmost one.
This patch introduces a helper to emulate the non-existing fremovexattrat()
function: it is implemented with /proc/self/fd which provides a trusted
path that can be safely passed to lremovexattr().
local_lremovexattr() is converted to use this helper and opendir_nofollow().
This partly fixes CVE-2016-9602.
Signed-off-by: Greg Kurz <groug@kaod.org>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
The local_lremovexattr() callback is vulnerable to symlink attacks because
it calls lremovexattr() which follows symbolic links in all path elements
but the rightmost one.
This patch introduces a helper to emulate the non-existing fremovexattrat()
function: it is implemented with /proc/self/fd which provides a trusted
path that can be safely passed to lremovexattr().
local_lremovexattr() is converted to use this helper and opendir_nofollow().
This partly fixes CVE-2016-9602.
Signed-off-by: Greg Kurz <groug@kaod.org>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
| hw/9pfs/9p-posix-acl.c | diffblobblamehistory | |
| hw/9pfs/9p-xattr-user.c | diffblobblamehistory | |
| hw/9pfs/9p-xattr.c | diffblobblamehistory | |
| hw/9pfs/9p-xattr.h | diffblobblamehistory |