spapr_pci: (Mostly) remove spapr-pci-vfio-host-bridge
commit72700d7e733948fa7fbb735ccdf2209931c88476
authorDavid Gibson <david@gibson.dropbear.id.au>
Mon, 29 Feb 2016 06:19:50 +0000 (29 17:19 +1100)
committerDavid Gibson <david@gibson.dropbear.id.au>
Tue, 15 Mar 2016 22:55:11 +0000 (16 09:55 +1100)
tree25eaafffe0e721b99d5c300d431fd95b7e23c9ba
parentc1fa017c7e9b017ec0a75f8added7f9c4864fe8a
spapr_pci: (Mostly) remove spapr-pci-vfio-host-bridge

Now that the regular spapr-pci-host-bridge can handle EEH, there are only
two things that spapr-pci-vfio-host-bridge does differently:
    1. automatically sizes its DMA window to match the host IOMMU
    2. checks if the attached VFIO container is backed by the
       VFIO_SPAPR_TCE_IOMMU type on the host

(1) is not particularly useful, since the default window used by the
regular host bridge will work with the host IOMMU configuration on all
current systems anyway.

Plus, automatically changing guest visible configuration (such as the DMA
window) based on host settings is generally a bad idea.  It's not
definitively broken, since spapr-pci-vfio-host-bridge is only supposed to
support VFIO devices which can't be migrated anyway, but still.

(2) is not really useful, because if a guest tries to configure EEH on a
different host IOMMU, the first call will fail and that will be that.

It's possible there are scripts or tools out there which expect
spapr-pci-vfio-host-bridge, so we don't remove it entirely.  This patch
reduces it to just a stub for backwards compatibility.

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Reviewed-by: Alexey Kardashevskiy <aik@ozlabs.ru>
hw/ppc/spapr_pci_vfio.c
include/hw/pci-host/spapr.h