qapi: Move check for reserved names out of add_name()
commit67fa64ce0ef92943a25de0f0760f8cfc10c2bbf3
authorMarkus Armbruster <armbru@redhat.com>
Fri, 27 Sep 2019 13:46:25 +0000 (27 15:46 +0200)
committerMarkus Armbruster <armbru@redhat.com>
Sat, 28 Sep 2019 15:17:19 +0000 (28 17:17 +0200)
tree2ea0aee90884c849a978fdacdcc3d6b36ee3403c
parent64e04f7149dd7f0f32b8e7aa5a89a0c1e6d0b5d6
qapi: Move check for reserved names out of add_name()

The checks for reserved names are spread far and wide.  Move one from
add_name() to new check_defn_name_str().  This is a first step towards
collecting them all in dedicated name checking functions next to
check_name().

While there, drop the quotes around the meta-type in
check_name_str()'s error messages: "'command' uses ... name 'NAME'"
becomes "command uses ... name 'NAME'".

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-Id: <20190927134639.4284-13-armbru@redhat.com>
scripts/qapi/common.py
tests/qapi-schema/bad-ident.err
tests/qapi-schema/reserved-command-q.err