python/aqmp: fix race condition in legacy.py
commit673856f9d889dc50b6a1a7964df960c4f00c7c93
authorJohn Snow <jsnow@redhat.com>
Fri, 25 Feb 2022 20:59:47 +0000 (25 15:59 -0500)
committerJohn Snow <jsnow@redhat.com>
Mon, 7 Mar 2022 19:36:41 +0000 (7 14:36 -0500)
treef2286866c6e5c624df1c8ca80ff78f7052161b34
parent481607c7d35de2bc4d9bec7f4734036fc467f330
python/aqmp: fix race condition in legacy.py

legacy.py provides a synchronous model. iotests frequently uses this
paradigm:

 - create QMP client object
 - start QEMU process
 - await connection from QEMU process

In the switch from sync to async QMP, the QMP client object stopped
calling bind() and listen() during the QMP object creation step, which
creates a race condition if the QEMU process dials in too quickly.

With refactoring out of the way, restore the former behavior of calling
bind() and listen() during __init__() to fix this race condition.

Signed-off-by: John Snow <jsnow@redhat.com>
Acked-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-id: 20220225205948.3693480-10-jsnow@redhat.com
[Expanded commit message. --js]
Signed-off-by: John Snow <jsnow@redhat.com>
python/qemu/aqmp/legacy.py