spapr: Clean up DRC set_allocation_state path
commit617367321ed6c66118fa981cf61c897f679ab021
authorDavid Gibson <david@gibson.dropbear.id.au>
Wed, 7 Jun 2017 14:50:19 +0000 (8 00:50 +1000)
committerDavid Gibson <david@gibson.dropbear.id.au>
Fri, 30 Jun 2017 04:03:32 +0000 (30 14:03 +1000)
treef6d2a3ce4e50e97badca0c1fc8446efae0c16708
parent4f9242fc931ab5e5b1b753c8e5a76c50c0b0612e
spapr: Clean up DRC set_allocation_state path

The allocation-state indicator should only actually be implemented for
"logical" DRCs, not physical ones.  Factor a check for this, and also for
valid indicator state values into rtas_set_allocation_state().  Because
they don't exist for physical DRCs, there's no reason that we'd ever want
more than one method implementation, so it can just be a plain function.

In addition, the setting to USABLE and setting to UNUSABLE paths in
set_allocation_state() don't actually have much in common.  So, split the
method separate functions for each parameter value (drc_set_usable()
and drc_set_unusable()).

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Reviewed-by: Greg Kurz <groug@kaod.org>
Reviewed-by: Michael Roth <mdroth@linux.vnet.ibm.com>
hw/ppc/spapr_drc.c
include/hw/ppc/spapr_drc.h