virtio/vhost: reset dev->log after syncing
commit5c0ba1be37181bd8a7c96c7f81b19ae5f8e66e2d
authorFelipe Franciosi <felipe@nutanix.com>
Wed, 20 Sep 2017 18:53:06 +0000 (20 11:53 -0700)
committerMichael S. Tsirkin <mst@redhat.com>
Sun, 15 Oct 2017 02:54:41 +0000 (15 05:54 +0300)
tree16cb6b7509dd5e8c38af51364adfd27ce8568cac
parent3505a22bcb6a220545894264b3dacbb164a0669b
virtio/vhost: reset dev->log after syncing

vhost_log_put() is called to decomission the dirty log between qemu and
a vhost device when stopping the device. Such a call can happen from
migration_completion().

Present code sets dev->log_size to zero too early in vhost_log_put(),
causing the sync check to always return false. As a consequence, the
last pass on the dirty bitmap never happens at the end of migration.

If a vhost device was busy (writing to guest memory) until the last
moments before vhost_virtqueue_stop(), this error will result in guest
memory corruption (at least) following migrations.

Signed-off-by: Felipe Franciosi <felipe@nutanix.com>
Acked-by: Jason Wang <jasowang@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
hw/virtio/vhost.c