block: Check for inserted BlockDriverState in blk_io_limits_disable()
commit48bf7ea81aa848027bad24f7e7791b503dff727d
authorAlberto Garcia <berto@igalia.com>
Fri, 10 Nov 2017 18:54:46 +0000 (10 20:54 +0200)
committerStefan Hajnoczi <stefanha@redhat.com>
Mon, 13 Nov 2017 14:38:46 +0000 (13 14:38 +0000)
tree64a14637234bf47665e375882015b3687773f100
parentdc868fb03b9b829ed9d2ecdae0fcc12f3fe19b4f
block: Check for inserted BlockDriverState in blk_io_limits_disable()

When you set I/O limits using block_set_io_throttle or the command
line throttling.* options they are kept in the BlockBackend regardless
of whether a BlockDriverState is attached to the backend or not.

Therefore when removing the limits using blk_io_limits_disable() we
need to check if there's a BDS before attempting to drain it, else it
will crash QEMU. This can be reproduced very easily using HMP:

     (qemu) drive_add 0 if=none,throttling.iops-total=5000
     (qemu) drive_del none0

Reported-by: sochin jiang <sochin.jiang@huawei.com>
Signed-off-by: Alberto Garcia <berto@igalia.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Message-id: 0d3a67ce8d948bb33e08672564714dcfb76a3d8c.1510339534.git.berto@igalia.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
block/block-backend.c