| commit | 382b6f22258f3e68c6a4226790eae96e5527e791 | |
| author | Alexey Kardashevskiy <aik@ozlabs.ru> | |
| Fri, 1 Feb 2019 00:56:22 +0000 (1 11:56 +1100) | ||
| committer | David Gibson <david@gibson.dropbear.id.au> | |
| Mon, 4 Feb 2019 07:44:20 +0000 (4 18:44 +1100) | ||
| tree | 1439f080df27601ff2fb84b20d51fc176257e9db | treesnapshot (tar.gz zip) |
| parent | 60594fea298d1e014700cc63a92ee43258c8c504 | commitdiff |
spapr_pci: Fix endianness in assigned-addresses property
reg->phys_hi and assigned->phys_hi are big endian but we do an extra
byteswap anyway when copying reg->phys_hi to assigned->phys_hi.
To make things slightly more messy, we also add a relocatable bit (b_n())
although in the right endianness.
This fixes endianness of assigned->phys_hi.
This is unlikely to produce any visible difference though as we should end up
there only in the case of PCI hotplug and even then I am not sure if
(d->io_regions[i].addr == PCI_BAR_UNMAPPED) == true.
Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
reg->phys_hi and assigned->phys_hi are big endian but we do an extra
byteswap anyway when copying reg->phys_hi to assigned->phys_hi.
To make things slightly more messy, we also add a relocatable bit (b_n())
although in the right endianness.
This fixes endianness of assigned->phys_hi.
This is unlikely to produce any visible difference though as we should end up
there only in the case of PCI hotplug and even then I am not sure if
(d->io_regions[i].addr == PCI_BAR_UNMAPPED) == true.
Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
| hw/ppc/spapr_pci.c | diffblobblamehistory |