| commit | 3579d606a091eb698cd53cef64e48cfa08cd7805 | |
| author | David Gibson <david@gibson.dropbear.id.au> | |
| Mon, 17 Jul 2017 04:51:09 +0000 (17 14:51 +1000) | ||
| committer | David Gibson <david@gibson.dropbear.id.au> | |
| Mon, 17 Jul 2017 05:06:08 +0000 (17 15:06 +1000) | ||
| tree | 94f9620d65e5e5ac74e6c1dfb5309336d9cf4127 | treesnapshot (tar.gz zip) |
| parent | 4871b51b9241b10f4fd8e04bbb21577886795e25 | commitdiff |
spapr: Remove unnecessary instance_size specifications from DRC subtypes
All the DRC subtypes explicitly list instance_size in TypeInfo (all as
sizeof(sPAPRDRConnector). This isn't necessary, since if it's not listed
it will be derived from the parent type.
Worse, this is dangerous, because if a subtype is changed in future to
have a larger structure, then subtypes of that subtype also need to have
instance_size changed, or it will lead to hard to track memory corruption
bugs.
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
All the DRC subtypes explicitly list instance_size in TypeInfo (all as
sizeof(sPAPRDRConnector). This isn't necessary, since if it's not listed
it will be derived from the parent type.
Worse, this is dangerous, because if a subtype is changed in future to
have a larger structure, then subtypes of that subtype also need to have
instance_size changed, or it will lead to hard to track memory corruption
bugs.
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
| hw/ppc/spapr_drc.c | diffblobblamehistory |