misc: Avoid UTF-8 in error messages
commit3381466dc95f5ee7087caa8fee77920bc03b0e62
authorEric Blake <eblake@redhat.com>
Tue, 20 Nov 2018 20:36:28 +0000 (20 14:36 -0600)
committerLaurent Vivier <laurent@vivier.eu>
Tue, 11 Dec 2018 17:28:46 +0000 (11 18:28 +0100)
tree7d6e75fb956fa7e78b697f30c848629e48aee95f
parentbf582c3461b23b1b9f1565d0ffbdc9e1ce076f8e
misc: Avoid UTF-8 in error messages

While most developers are now using UTF-8 environments, it's
harder to guarantee that error messages will be output to
a multibyte locale. Rather than risking error messages that
get corrupted into mojibake when the user runs qemu in a
non-multibyte locale, let's stick to straight ASCII error
messages, rather than assuming that our use of UTF-8 in source
code string constants will work unchanged in other locales.

Found with:
$ LC_ALL=C git grep -l $'".*[\x80-\xff].*"' origin -- '**/*.[ch]' | cat
origin:hw/misc/tmp105.c
origin:hw/misc/tmp421.c

Reported-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20181120203628.2367003-1-eblake@redhat.com>
[lv: added command line to find non ASCII characters]
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
hw/misc/tmp105.c
hw/misc/tmp421.c