tests: wait max 120 seconds for migration test status changes
commit276dfd03f00358ba904ca1954d3671f94949fbf6
authorDaniel P. Berrangé <berrange@redhat.com>
Tue, 28 Jun 2022 10:54:30 +0000 (28 11:54 +0100)
committerThomas Huth <thuth@redhat.com>
Tue, 5 Jul 2022 07:33:58 +0000 (5 09:33 +0200)
tree677a6b688c103f9574e0fad09ad6f14f96fc600b
parent3a751770ee687047230eca5f25ce3844b97cd713
tests: wait max 120 seconds for migration test status changes

Currently the wait_for_migration_fail and wait_for_migration_complete
functions will spin in an infinite loop checking query-migrate status
to detect a specific change/goal. This is fine when everything goes
to plan, but when the unusual happens, these will hang the test suite
forever.

Any normally executing migration test case normally takes < 1 second
for a state change, with exception of the autoconverge test which
takes about 5 seconds. Taking into account possibility of people
running tests inside TCG, allowing a factor of x20 slowdown gives
a reasonable worst case of 120 seconds. Anything taking longer than
this is a strong sign that the test has hung, or the test should be
rewritten to be faster.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Message-Id: <20220628105434.295905-2-berrange@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
tests/qtest/migration-helpers.c