tcg/{i386, s390x}: Add earlyclobber to the op_add2's first output
commit22d2e5351a18aff5a9c7e3984b50ecce61ff8975
authorIlya Leoshkevich <iii@linux.ibm.com>
Wed, 19 Jul 2023 22:11:18 +0000 (20 00:11 +0200)
committerRichard Henderson <richard.henderson@linaro.org>
Sun, 23 Jul 2023 16:58:19 +0000 (23 17:58 +0100)
tree46e1fca0b8b066a69b85bae613190e1827091346
parent2c8412d469707124c6f471822aff2e2cab395907
tcg/{i386, s390x}: Add earlyclobber to the op_add2's first output

i386 and s390x implementations of op_add2 require an earlyclobber,
which is currently missing. This breaks VCKSM in s390x guests. E.g., on
x86_64 the following op:

    add2_i32 tmp2,tmp3,tmp2,tmp3,tmp3,tmp2   dead: 0 2 3 4 5  pref=none,0xffff

is translated to:

    addl     %ebx, %r12d
    adcl     %r12d, %ebx

Introduce a new C_N1_O1_I4 constraint, and make sure that earlyclobber
of aliased outputs is honored.

Cc: qemu-stable@nongnu.org
Fixes: 82790a870992 ("tcg: Add markup for output requires new register")
Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20230719221310.1968845-7-iii@linux.ibm.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
tcg/i386/tcg-target-con-set.h
tcg/i386/tcg-target.c.inc
tcg/s390x/tcg-target-con-set.h
tcg/s390x/tcg-target.c.inc
tcg/tcg.c