| commit | 21bb3093e6accd2d7d60531a472a34e40911acd9 | |
| author | David Gibson <david@gibson.dropbear.id.au> | |
| Tue, 12 Jul 2016 06:54:03 +0000 (12 16:54 +1000) | ||
| committer | David Gibson <david@gibson.dropbear.id.au> | |
| Mon, 18 Jul 2016 00:40:27 +0000 (18 10:40 +1000) | ||
| tree | 6f043b059e94452ae07890a5866206c8f04edb33 | treesnapshot (tar.gz zip) |
| parent | 36a24df84a4728b1cd7425af24c0d30cd65a51b5 | commitdiff |
vfio/spapr: Remove stale ioctl() call
This ioctl() call to VFIO_IOMMU_SPAPR_TCE_REMOVE was left over from an
earlier version of the code and has since been folded into
vfio_spapr_remove_window().
It wasn't caught because although the argument structure has been removed,
the libc function remove() means this didn't trigger a compile failure.
The ioctl() was also almost certain to fail silently and harmlessly with
the bogus argument, so this wasn't caught in testing.
Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Reviewed-by: Alexey Kardashevskiy <aik@ozlabs.ru>
This ioctl() call to VFIO_IOMMU_SPAPR_TCE_REMOVE was left over from an
earlier version of the code and has since been folded into
vfio_spapr_remove_window().
It wasn't caught because although the argument structure has been removed,
the libc function remove() means this didn't trigger a compile failure.
The ioctl() was also almost certain to fail silently and harmlessly with
the bogus argument, so this wasn't caught in testing.
Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Reviewed-by: Alexey Kardashevskiy <aik@ozlabs.ru>
| hw/vfio/spapr.c | diffblobblamehistory |