virtiofsd: Don't allow empty paths in lookup_name()
commit20afcc23b3212784c84fb06062f66d9d2ce6865d
authorGreg Kurz <groug@kaod.org>
Fri, 12 Mar 2021 14:10:01 +0000 (12 15:10 +0100)
committerDr. David Alan Gilbert <dgilbert@redhat.com>
Mon, 15 Mar 2021 20:01:55 +0000 (15 20:01 +0000)
tree8053dcfdbcc623cdd349500a7157840deb736b4c
parent28d1ad0ea41342472afda15b515d95671eac4030
virtiofsd: Don't allow empty paths in lookup_name()

When passed an empty filename, lookup_name() returns the inode of
the parent directory, unless the parent is the root in which case
the st_dev doesn't match and lo_find() returns NULL. This is
because lookup_name() passes AT_EMPTY_PATH down to fstatat() or
statx().

This behavior doesn't quite make sense because users of lookup_name()
then pass the name to unlinkat(), renameat() or renameat2(), all of
which will always fail on empty names.

Drop AT_EMPTY_PATH from the flags in lookup_name() so that it has
the consistent behavior of "returning an existing child inode or
NULL" for all directories.

Signed-off-by: Greg Kurz <groug@kaod.org>
Message-Id: <20210312141003.819108-2-groug@kaod.org>
Reviewed-by: Connor Kuehl <ckuehl@redhat.com>
Reviewed-by: Vivek Goyal <vgoyal@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
tools/virtiofsd/passthrough_ll.c