ui/cocoa: Remove the uses of full screen APIs
commit1e8b6f2b4989d3d2567befa00cd9c4430190f433
authorAkihiko Odaki <akihiko.odaki@gmail.com>
Sat, 20 Feb 2021 01:31:38 +0000 (20 10:31 +0900)
committerGerd Hoffmann <kraxel@redhat.com>
Wed, 3 Mar 2021 07:47:42 +0000 (3 08:47 +0100)
tree9844574c0cd20b1f3048c4a36daf34b058ee4e59
parentcbcf09872a936ccefef6a34298046d3b9aefc148
ui/cocoa: Remove the uses of full screen APIs

The detections of [NSView -enterFullScreen:] and
[NSView -exitFullScreen:] were wrong. A detection is coded as:
[NSView respondsToSelector:@selector(exitFullScreenModeWithOptions:)]
but it should be:
[NSView instancesRespondToSelector:@selector(exitFullScreenModeWithOptions:)]

Because of those APIs were not detected, ui/cocoa always falled
back to a borderless window whose frame matches the screen to
implement fullscreen behavior.

The code using [NSView -enterFullScreen:] and
[NSView -exitFullScreen:] will be used if you fix the detections,
but its behavior is undesirable; the full screen view stretches
the video, changing the aspect ratio, even if zooming is disabled.

This change removes the code as it does nothing good.

Signed-off-by: Akihiko Odaki <akihiko.odaki@gmail.com>
Message-Id: <20210220013138.51437-1-akihiko.odaki@gmail.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
ui/cocoa.m