| commit | 1ca15d85ab0d2a53f86a16b75468633938467cd8 | |
| author | Thomas Huth <thuth@redhat.com> | |
| Wed, 7 Mar 2018 14:22:54 +0000 (7 15:22 +0100) | ||
| committer | David Gibson <david@gibson.dropbear.id.au> | |
| Sun, 18 Mar 2018 07:27:23 +0000 (18 18:27 +1100) | ||
| tree | 746ec5a1d051c03c252bdd48c07375a1af1c8a99 | treesnapshot (tar.gz zip) |
| parent | b891538e81d33e59e1df9ce489e7118b7a1e7857 | commitdiff |
hw/misc/macio: Mark the macio devices with user_creatable = false
The macio devices currently cause a crash when the user tries to
instantiate them on a different machine:
$ ppc64-softmmu/qemu-system-ppc64 -device macio-newworld
Unexpected error in qemu_chr_fe_init() at chardev/char-fe.c:222:
qemu-system-ppc64: -device macio-newworld: Device 'serial0' is in use
Aborted (core dumped)
These devices are clearly not intended to be creatable by the user
since they are using serial_hds[] directly in their instance_init
function. So let's mark them with user_creatable = false.
Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
The macio devices currently cause a crash when the user tries to
instantiate them on a different machine:
$ ppc64-softmmu/qemu-system-ppc64 -device macio-newworld
Unexpected error in qemu_chr_fe_init() at chardev/char-fe.c:222:
qemu-system-ppc64: -device macio-newworld: Device 'serial0' is in use
Aborted (core dumped)
These devices are clearly not intended to be creatable by the user
since they are using serial_hds[] directly in their instance_init
function. So let's mark them with user_creatable = false.
Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
| hw/misc/macio/macio.c | diffblobblamehistory |