| commit | 1bf57fb3df9615b50219c50b381cc52e303f682c | |
| author | Wei Yang <richardw.yang@linux.intel.com> | |
| Wed, 11 Sep 2019 13:28:39 +0000 (11 13:28 +0000) | ||
| committer | Dr. David Alan Gilbert <dgilbert@redhat.com> | |
| Thu, 12 Sep 2019 10:23:32 +0000 (12 11:23 +0100) | ||
| tree | ac3d66c60d945acf42e15580f70fdcae5f750b2d | treesnapshot (tar.gz zip) |
| parent | 89fe04b4585c97fda7c173bee97bbacb32f64e80 | commitdiff |
migration/qemu-file: fix potential buf waste for extra buf_index adjustment
In add_to_iovec(), qemu_fflush() will be called if iovec is full. If
this happens, buf_index is reset. Currently, this is not checked and
buf_index would always been adjust with buf size.
This is not harmful, but will waste some space in file buffer.
This patch make add_to_iovec() return 1 when it has flushed the file.
Then the caller could check the return value to see whether it is
necessary to adjust the buf_index any more.
Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Message-Id: <20190911132839.23336-3-richard.weiyang@gmail.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
In add_to_iovec(), qemu_fflush() will be called if iovec is full. If
this happens, buf_index is reset. Currently, this is not checked and
buf_index would always been adjust with buf size.
This is not harmful, but will waste some space in file buffer.
This patch make add_to_iovec() return 1 when it has flushed the file.
Then the caller could check the return value to see whether it is
necessary to adjust the buf_index any more.
Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Message-Id: <20190911132839.23336-3-richard.weiyang@gmail.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
| migration/qemu-file.c | diffblobblamehistory |