| commit | 16617e36b02ebdc83f215d89db9ac00f7d6d6d83 | |
| author | Jason Wang <jasowang@redhat.com> | |
| Fri, 29 May 2015 06:13:14 +0000 (29 14:13 +0800) | ||
| committer | Michael S. Tsirkin <mst@redhat.com> | |
| Tue, 23 Jun 2015 15:08:21 +0000 (23 17:08 +0200) | ||
| tree | bae0f0a576a8b0a0f7389f79a0aaf38d5593f8b8 | treesnapshot (tar.gz zip) |
| parent | e3816255bf4b6377bb405331e2ee0dc14d841b80 | commitdiff |
vhost: correctly pass error to caller in vhost_dev_enable_notifiers()
We override the error value r in fail_vq, this will cause the caller
can't detect the failure which may cause the caller may disable the
notifiers twice if vhost is failed to start. Fix this by using another
variable to keep track the return value of set_host_notifier().
Fixes b0b3db79559e57db340b292621c397e7a6cdbdc5 ("vhost-net: cleanup
host notifiers at last step")
Cc: qemu-stable@nongnu.org
Cc: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
We override the error value r in fail_vq, this will cause the caller
can't detect the failure which may cause the caller may disable the
notifiers twice if vhost is failed to start. Fix this by using another
variable to keep track the return value of set_host_notifier().
Fixes b0b3db79559e57db340b292621c397e7a6cdbdc5 ("vhost-net: cleanup
host notifiers at last step")
Cc: qemu-stable@nongnu.org
Cc: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
| hw/virtio/vhost.c | diffblobblamehistory |