| commit | 0e22a2d18998fd183c8181663981eb681ca977e9 | |
| author | Stefan Hajnoczi <stefanha@redhat.com> | |
| Thu, 30 May 2013 14:14:44 +0000 (30 16:14 +0200) | ||
| committer | Paolo Bonzini <pbonzini@redhat.com> | |
| Tue, 18 Jun 2013 10:43:03 +0000 (18 12:43 +0200) | ||
| tree | da68b667eb49f9c33fdfe13a945a5d8f3c2ebda2 | treesnapshot (tar.gz zip) |
| parent | 18e673b8f350e1d789b8a50d209eb4a4252ebbda | commitdiff |
vhost-scsi: fix k->set_guest_notifiers() NULL dereference
Coverity picked up a copy-paste bug. In vhost_scsi_start() we check for
!k->set_guest_notifiers and error out. The check probably got copied
but instead of erroring we actually use the function pointer!
Cc: Nicholas Bellinger <nab@linux-iscsi.org>
Cc: Asias He <asias@redhat.com>
Cc: qemu-stable@nongnu.org
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Coverity picked up a copy-paste bug. In vhost_scsi_start() we check for
!k->set_guest_notifiers and error out. The check probably got copied
but instead of erroring we actually use the function pointer!
Cc: Nicholas Bellinger <nab@linux-iscsi.org>
Cc: Asias He <asias@redhat.com>
Cc: qemu-stable@nongnu.org
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
| hw/scsi/vhost-scsi.c | diffblobblamehistory |