| commit | 09f1bbcd834c63da35b3fe190fcd9a20d7b04f07 | |
| author | Michael Roth <mdroth@linux.vnet.ibm.com> | |
| Sun, 4 Mar 2012 19:38:27 +0000 (4 13:38 -0600) | ||
| committer | Andreas Färber <afaerber@suse.de> | |
| Fri, 8 Jun 2012 14:11:14 +0000 (8 16:11 +0200) | ||
| tree | 49be20255dd293b1af972a1d7b8cd4cd6e9d87ae | treesnapshot (tar.gz zip) |
| parent | 0d30b0a2d338cd5f463a0fd3942d19f70eb6db56 | commitdiff |
qdev: Use int32_t container for devfn property
Valid range for devfn is -1 to 255 (-1 for automatic assignment). We do
not currently validate this due to devfn being stored as a uint32_t.
This can lead to segfaults and other strange behavior.
We could technically just cast it to int32_t to implement the checking,
but this will not work for visitor-based setting where we may do additional
bounds-checking based on target container type, which is int32_t for this
case.
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>
Valid range for devfn is -1 to 255 (-1 for automatic assignment). We do
not currently validate this due to devfn being stored as a uint32_t.
This can lead to segfaults and other strange behavior.
We could technically just cast it to int32_t to implement the checking,
but this will not work for visitor-based setting where we may do additional
bounds-checking based on target container type, which is int32_t for this
case.
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>
| hw/pci.c | diffblobblamehistory | |
| hw/pci.h | diffblobblamehistory | |
| hw/qdev-properties.c | diffblobblamehistory | |
| hw/qdev.h | diffblobblamehistory |