| commit | 0002b557b5c8b013087fc18d75d370f11783f619 | |
| author | Markus Armbruster <armbru@redhat.com> | |
| Fri, 18 Oct 2019 07:43:41 +0000 (18 09:43 +0200) | ||
| committer | Markus Armbruster <armbru@redhat.com> | |
| Tue, 22 Oct 2019 07:26:12 +0000 (22 09:26 +0200) | ||
| tree | 90dd293aa8eaac937efba93625f0db5d8d9a6356 | treesnapshot (tar.gz zip) |
| parent | 2a7bbedd7752b77d91eb2db0e8dea23852ce556b | commitdiff |
qapi: Eliminate accidental global frontend state
The frontend can't be run more than once due to its global state.
A future commit will want to do that.
The only global frontend state remaining is accidental:
QAPISchemaParser.__init__()'s parameter previously_included=[].
Python evaluates the default once, at definition time. Any
modifications to it are visible in subsequent calls. Well-known
Python trap. Change the default to None and replace it by the real
default in the function body. Use the opportunity to convert
previously_included to a set.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-Id: <20191018074345.24034-4-armbru@redhat.com>
The frontend can't be run more than once due to its global state.
A future commit will want to do that.
The only global frontend state remaining is accidental:
QAPISchemaParser.__init__()'s parameter previously_included=[].
Python evaluates the default once, at definition time. Any
modifications to it are visible in subsequent calls. Well-known
Python trap. Change the default to None and replace it by the real
default in the function body. Use the opportunity to convert
previously_included to a set.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-Id: <20191018074345.24034-4-armbru@redhat.com>
| scripts/qapi/common.py | diffblobblamehistory |