| commit | dabfa6cc2e2a06269026fcb42772894f67bd0c3e | |
| author | Kevin Wolf <kwolf@redhat.com> | |
| Fri, 24 Jan 2014 13:00:43 +0000 (24 14:00 +0100) | ||
| committer | Kevin Wolf <kwolf@redhat.com> | |
| Fri, 24 Jan 2014 15:53:51 +0000 (24 16:53 +0100) | ||
| tree | bacbce1eb4e48ba7397b78bc0128af073cf61555 | treesnapshot (tar.gz zip) |
| parent | 37222900743962e146a82b7077a18c3f39859a19 | commitdiff |
block: Fix bdrv_commit return value
bdrv_commit() could return 0 or 1 on success, depending on whether or
not the last sector was allocated in the overlay and whether the overlay
format had a .bdrv_make_empty callback.
Most callers ignored it, but qemu-img commit would print an error
message while the operation actually succeeded.
Also clean up the handling of I/O errors to return the real error code
instead of -EIO.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Benoit Canet <benoit@irqsave.net>
bdrv_commit() could return 0 or 1 on success, depending on whether or
not the last sector was allocated in the overlay and whether the overlay
format had a .bdrv_make_empty callback.
Most callers ignored it, but qemu-img commit would print an error
message while the operation actually succeeded.
Also clean up the handling of I/O errors to return the real error code
instead of -EIO.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Benoit Canet <benoit@irqsave.net>
| block.c | diffblobblamehistory |