| commit | 81aab2ff1118a4de8fd92ae89380ccfbc2870574 | |
| author | Markus Armbruster <armbru@redhat.com> | |
| Thu, 28 Nov 2013 16:27:00 +0000 (28 17:27 +0100) | ||
| committer | Andreas Färber <afaerber@suse.de> | |
| Sun, 22 Dec 2013 23:27:23 +0000 (23 00:27 +0100) | ||
| tree | d1701f2f4b2615d234422abc9484c10b769ef67f | treesnapshot (tar.gz zip) |
| parent | bfa6dfd070f0cb5be37ae3bd6b90bdd67849c311 | commitdiff |
piix3 piix4: Clean up use of cannot_instantiate_with_device_add_yet
A PIIX3/PIIX4 southbridge has multiple functions. We model each
function as a separate qdev. Two of them need some special wiring set
up in pc_init1() or mips_malta_init() to work: the ISA bridge at 01.0,
and the SMBus controller at 01.3.
The IDE controller at 01.1 (piix3-ide, piix3-ide-xen, piix4-ide) has
always had cannot_instantiate_with_device_add_yet set, but there is no
obvious reason why device_add could not work for them. Drop it.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Marcel Apfelbaum <marcel.a@redhat.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>
A PIIX3/PIIX4 southbridge has multiple functions. We model each
function as a separate qdev. Two of them need some special wiring set
up in pc_init1() or mips_malta_init() to work: the ISA bridge at 01.0,
and the SMBus controller at 01.3.
The IDE controller at 01.1 (piix3-ide, piix3-ide-xen, piix4-ide) has
always had cannot_instantiate_with_device_add_yet set, but there is no
obvious reason why device_add could not work for them. Drop it.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Marcel Apfelbaum <marcel.a@redhat.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>
| hw/acpi/piix4.c | diffblobblamehistory | |
| hw/ide/piix.c | diffblobblamehistory | |
| hw/isa/piix4.c | diffblobblamehistory | |
| hw/pci-host/piix.c | diffblobblamehistory |