| commit | 71c265816dd2772f89ebb377381c836dfca09d70 | |
| author | Markus Armbruster <armbru@redhat.com> | |
| Tue, 15 Mar 2016 18:34:30 +0000 (15 19:34 +0100) | ||
| committer | Markus Armbruster <armbru@redhat.com> | |
| Mon, 21 Mar 2016 20:29:00 +0000 (21 21:29 +0100) | ||
| tree | edcd0d6652cf93e454cbb0fa511d1d8ab74b2d23 | treesnapshot (tar.gz zip) |
| parent | c20fc0c3ee1ca83e6f3416acad31439bffed7977 | commitdiff |
ivshmem: Don't destroy the chardev on version mismatch
Yes, the chardev is commonly useless after we read a bad version from
it, but destroying it is inappropriate anyway: the user created it, so
the user should be able to hold on to it as long as he likes. We
don't destroy it on other errors. Screwed up in commit 5105b1d.
Stop reading instead.
Also note QEMU's behavior in ivshmem-spec.txt.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <1458066895-20632-16-git-send-email-armbru@redhat.com>
Yes, the chardev is commonly useless after we read a bad version from
it, but destroying it is inappropriate anyway: the user created it, so
the user should be able to hold on to it as long as he likes. We
don't destroy it on other errors. Screwed up in commit 5105b1d.
Stop reading instead.
Also note QEMU's behavior in ivshmem-spec.txt.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <1458066895-20632-16-git-send-email-armbru@redhat.com>
| docs/specs/ivshmem-spec.txt | diffblobblamehistory | |
| hw/misc/ivshmem.c | diffblobblamehistory |