vga: Replace VGA_COMMON with a structure
commit4e12cd946f9e7a6e3d35bcce0bc7bfe38cec4eb7
authorAvi Kivity <avi@redhat.com>
Sun, 3 May 2009 19:25:16 +0000 (3 22:25 +0300)
committerAnthony Liguori <aliguori@us.ibm.com>
Fri, 8 May 2009 21:11:38 +0000 (8 16:11 -0500)
tree1b3d29a0a137dac44efe97ac1e89e2d4ca8676c3
parentfbb7b4e0804d2168f24142eebf7552adde1968dc
vga: Replace VGA_COMMON with a structure

All VGA devices share a common field subset; currently they do so by
a macro which defines the common fields inline their state structures,
relying on the the common state being placed at offset 0 in the structure.
This makes refactoring the code difficult and requires a lot of error prone
casts.

Replace the macro by a new VGACommonState structure, and the casts by
regular field access and container_of() for upcasts.

Signed-off-by: Avi Kivity <avi@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
hw/cirrus_vga.c
hw/cirrus_vga_rop.h
hw/cirrus_vga_rop2.h
hw/vga_int.h
hw/vmware_vga.c