| commit | 365aa1131fa61815eb1d672df6ba451bfe7f2cea | |
| author | Igor Mammedov <imammedo@redhat.com> | |
| Thu, 14 Jul 2016 14:58:02 +0000 (14 16:58 +0200) | ||
| committer | Eduardo Habkost <ehabkost@redhat.com> | |
| Wed, 20 Jul 2016 15:02:19 +0000 (20 12:02 -0300) | ||
| tree | d23977362ee78f58e38701ab691d2e66009bcc03 | treesnapshot (tar.gz zip) |
| parent | 1dfe3282cf851dce186ab15b07225e5d8588b63f | commitdiff |
apic: kvm-apic: Fix crash due to access to freed memory region
kvm-apic.io_memory memory region had its parent set to NULL at
memory_region_init_io() time, so it ended up as a child in
/unattached contaner.
As result when kvm-apic instance was deleted, the child property
/unattached/kvm-apic-msi[XXX] contained a reference to
kvm-apic.io_memory address which was freed as part of kvm-apic.
Do the same as 'apic' and make kvm-apic instance the owner
of the memory region so that it won't end up in /unattached
and gets cleanly released along with related kvm-apic instance.
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
kvm-apic.io_memory memory region had its parent set to NULL at
memory_region_init_io() time, so it ended up as a child in
/unattached contaner.
As result when kvm-apic instance was deleted, the child property
/unattached/kvm-apic-msi[XXX] contained a reference to
kvm-apic.io_memory address which was freed as part of kvm-apic.
Do the same as 'apic' and make kvm-apic instance the owner
of the memory region so that it won't end up in /unattached
and gets cleanly released along with related kvm-apic instance.
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
| hw/i386/kvm/apic.c | diffblobblamehistory |