qdev: Add cleanup logic in device_set_realized() to avoid resource leak
commit1d45a705fc007a13f20d18473290082eae6d1725
authorGonglei <arei.gonglei@huawei.com>
Thu, 4 Sep 2014 02:18:26 +0000 (4 10:18 +0800)
committerAndreas Färber <afaerber@suse.de>
Thu, 4 Sep 2014 17:15:54 +0000 (4 19:15 +0200)
treec6e0f9d78ab7caa53cef2068362c2df64ab5540d
parentcd4520adcab70dbac8db3fe4d41836dca63715a4
qdev: Add cleanup logic in device_set_realized() to avoid resource leak

At present, this function doesn't have partial cleanup implemented,
which will cause resource leaks in some scenarios.

Example:

1. Assume that "dc->realize(dev, &local_err)" executes successful
   and local_err == NULL;
2. device hotplug in hotplug_handler_plug() executes but fails
   (it is prone to occur). Then local_err != NULL;
3. error_propagate(errp, local_err) and return. But the resources
   which have been allocated in dc->realize() will be leaked.
Simple backtrace:
  dc->realize()
   |->device_realize
            |->pci_qdev_init()
                |->do_pci_register_device()
                |->etc.

Add fuller cleanup logic which assures that function can
goto appropriate error label as local_err population is
detected at each relevant point.

Signed-off-by: Gonglei <arei.gonglei@huawei.com>
Reviewed-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Cc: qemu-stable@nongnu.org
Signed-off-by: Andreas Färber <afaerber@suse.de>
hw/core/qdev.c