| commit | 06a1307379fcd6c551185ad87679cd7ed896b9ea | |
| author | Paolo Bonzini <pbonzini@redhat.com> | |
| Fri, 20 Sep 2013 12:10:26 +0000 (20 14:10 +0200) | ||
| committer | Paolo Bonzini <pbonzini@redhat.com> | |
| Mon, 9 Dec 2013 20:46:48 +0000 (9 21:46 +0100) | ||
| tree | fe5261c40d362e495507fe290dfafa481a13b643 | treesnapshot (tar.gz zip) |
| parent | 7bb6edb0e3dd78d74e0ac980cf6c0a07307f61bf | commitdiff |
virtio-pci: add device_unplugged callback
This fixes a crash in hot-unplug of virtio-pci devices behind a PCIe
switch. The crash happens because the ioeventfd is still set whent the
child is destroyed (destruction happens in postorder). Then the proxy
tries to unset to ioeventfd, but the virtqueue structure that holds the
EventNotifier has been trashed in the meanwhile. kvm_set_ioeventfd_pio
does not expect failure and aborts.
The fix is simply to move parts of uninitialization to a new
device_unplugged callback, which is called before the child is destroyed.
Cc: qemu-stable@nongnu.org
Acked-by: Andreas Faerber <afaerber@suse.de>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
This fixes a crash in hot-unplug of virtio-pci devices behind a PCIe
switch. The crash happens because the ioeventfd is still set whent the
child is destroyed (destruction happens in postorder). Then the proxy
tries to unset to ioeventfd, but the virtqueue structure that holds the
EventNotifier has been trashed in the meanwhile. kvm_set_ioeventfd_pio
does not expect failure and aborts.
The fix is simply to move parts of uninitialization to a new
device_unplugged callback, which is called before the child is destroyed.
Cc: qemu-stable@nongnu.org
Acked-by: Andreas Faerber <afaerber@suse.de>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
| hw/virtio/virtio-pci.c | diffblobblamehistory |