| commit | 024d9adc79651f8fd96078461a7e4dfb8bb83e16 | |
| author | Bin Wu <wu.wubin@huawei.com> | |
| Sat, 25 Oct 2014 02:43:44 +0000 (25 02:43 +0000) | ||
| committer | Paolo Bonzini <pbonzini@redhat.com> | |
| Mon, 27 Oct 2014 15:11:45 +0000 (27 16:11 +0100) | ||
| tree | f66fa9ee52e8e857bd41f985883666dd7b7d823e | treesnapshot (tar.gz zip) |
| parent | b7890c40e557f4733b6fcd1eb79af79b70dc8c05 | commitdiff |
hw/scsi/virtio-scsi.c: fix the "type" use error in virtio_scsi_handle_ctrl
The local variable "type" in virtio_scsi_handle_ctl represents the tmf
command type from the guest and it has the same meaning as the
req->req.tmf.type. However, before the invoking of virtio_scsi_parse_req
the req->req.tmf.type doesn't has the correct value(just initialized to
zero). Therefore, we need to use the "type" variable to judge the case.
Cc: qemu-stable@nongnu.org
Signed-off-by: Bin Wu <wu.wubin@huawei.com>
[Actually make it compile, "type" must be uint32_t in order to pass
it to virtio_tswap32s. - Paolo]
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
The local variable "type" in virtio_scsi_handle_ctl represents the tmf
command type from the guest and it has the same meaning as the
req->req.tmf.type. However, before the invoking of virtio_scsi_parse_req
the req->req.tmf.type doesn't has the correct value(just initialized to
zero). Therefore, we need to use the "type" variable to judge the case.
Cc: qemu-stable@nongnu.org
Signed-off-by: Bin Wu <wu.wubin@huawei.com>
[Actually make it compile, "type" must be uint32_t in order to pass
it to virtio_tswap32s. - Paolo]
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
| hw/scsi/virtio-scsi.c | diffblobblamehistory |