From b1c073490553f80594b903ceedfc7c1aef6b1b19 Mon Sep 17 00:00:00 2001 From: Hanna Reitz Date: Tue, 29 Mar 2022 11:35:45 +0200 Subject: [PATCH] main-loop: Disable GLOBAL_STATE_CODE() assertions MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit These assertions are very useful for developers to find bugs, and so they have indeed pointed us towards bugs already. For users, it is not so useful to find these bugs. We should probably not enable them in releases until we are sufficiently certain that they will not fire during normal operation, unless something is going seriously wrong. For example, we have received a bug report that you cannot add an NBD server on a BDS in an I/O thread with `-incoming defer`. I am sure this is a real bug that needs investigation, but we do not really have that time right now, so close to release, and so I would rather disable the assertions to get time to investigate such reports. (I am just putting the link as "buglink" below, not "closes", because disabling the assertion will not fix the likely underlying bug.) Buglink: https://gitlab.com/qemu-project/qemu/-/issues/945 Signed-off-by: Hanna Reitz Message-Id: <20220329093545.52114-1-hreitz@redhat.com> Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Reviewed-by: Emanuele Giuseppe Esposito --- include/qemu/main-loop.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/qemu/main-loop.h b/include/qemu/main-loop.h index 89bd9edefb..d3750c8e76 100644 --- a/include/qemu/main-loop.h +++ b/include/qemu/main-loop.h @@ -284,7 +284,8 @@ bool qemu_in_main_thread(void); #else #define GLOBAL_STATE_CODE() \ do { \ - assert(qemu_in_main_thread()); \ + /* FIXME: Re-enable after 7.0 release */ \ + /* assert(qemu_in_main_thread()); */ \ } while (0) #endif /* CONFIG_COCOA */ -- 2.11.4.GIT