From 039d4e3df0049bdd8f93a2de735a816483b13954 Mon Sep 17 00:00:00 2001 From: John Snow Date: Tue, 27 Nov 2018 13:49:29 -0500 Subject: [PATCH] scsi: Address spurious clang warning Some versions of Clang prior to 6.0 (and some builds of clang after, such as 6.0.1-2.fc28) fail to recognize { 0 } as a valid initializer for a struct with subobjects when -Wmissing-braces is enabled. https://bugs.llvm.org/show_bug.cgi?id=21689 and https://reviews.llvm.org/rL314499 suggests this should be fixed in 6.0, but it might not be the case for older versions or downstream versions. For now, follow the precedent of ebf2a499 and replace the standard { 0 } with the accepted { } to silence this warning and allow the build to work under clang 6.0.1-2.fc28, and builds prior to 6.0. Signed-off-by: John Snow Reviewed-by: Eric Blake Message-id: 20181127184929.20065-1-jsnow@redhat.com Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- scsi/qemu-pr-helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scsi/qemu-pr-helper.c b/scsi/qemu-pr-helper.c index ce40008bfc..e7af637232 100644 --- a/scsi/qemu-pr-helper.c +++ b/scsi/qemu-pr-helper.c @@ -236,7 +236,7 @@ static void dm_init(void) perror("Cannot open " CONTROL_PATH); exit(1); } - struct dm_ioctl dm = { 0 }; + struct dm_ioctl dm = { }; if (!dm_ioctl(DM_VERSION, &dm)) { perror("ioctl"); exit(1); -- 2.11.4.GIT