block/snapshot: Restrict set of snapshot nodes
commit05f4aced658a02b02d3e89a6c7a2281008fcf26c
authorKevin Wolf <kwolf@redhat.com>
Tue, 17 Sep 2019 10:26:23 +0000 (17 12:26 +0200)
committerKevin Wolf <kwolf@redhat.com>
Fri, 4 Oct 2019 09:52:40 +0000 (4 11:52 +0200)
tree8c222d072c6755c87c7db78e00c059be1320cb37
parent4f59102571fce49af180cfc6d4cdd2b5df7bdb14
block/snapshot: Restrict set of snapshot nodes

Nodes involved in internal snapshots were those that were returned by
bdrv_next(), inserted and not read-only. bdrv_next() in turn returns all
nodes that are either the root node of a BlockBackend or monitor-owned
nodes.

With the typical -drive use, this worked well enough. However, in the
typical -blockdev case, the user defines one node per option, making all
nodes monitor-owned nodes. This includes protocol nodes etc. which often
are not snapshottable, so "savevm" only returns an error.

Change the conditions so that internal snapshot still include all nodes
that have a BlockBackend attached (we definitely want to snapshot
anything attached to a guest device and probably also the built-in NBD
server; snapshotting block job BlockBackends is more of an accident, but
a preexisting one), but other monitor-owned nodes are only included if
they have no parents.

This makes internal snapshots usable again with typical -blockdev
configurations.

Cc: qemu-stable@nongnu.org
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
Tested-by: Peter Krempa <pkrempa@redhat.com>
block/snapshot.c