target: Clean up how the dump_mmu() print
commitfad866daa85c65267fa44de40f10cc1ee904ae1a
authorMarkus Armbruster <armbru@redhat.com>
Wed, 17 Apr 2019 19:17:58 +0000 (17 21:17 +0200)
committerMarkus Armbruster <armbru@redhat.com>
Thu, 18 Apr 2019 20:18:59 +0000 (18 22:18 +0200)
treeb94800a130298a2a9f6d9f41ad5692bf5fa6964e
parent0442428a8976b4f94e04d24b5db9eb1b678d82c4
target: Clean up how the dump_mmu() print

The various dump_mmu() take an fprintf()-like callback and a FILE * to
pass to it, and so do their helper functions.  Passing around callback
and argument is rather tiresome.

Most dump_mmu() are called only by the target's hmp_info_tlb().  These
all pass monitor_printf() cast to fprintf_function and the current
monitor cast to FILE *.

SPARC's dump_mmu() gets also called from target/sparc/ldst_helper.c a
few times #ifdef DEBUG_MMU.  These calls pass fprintf() and stdout.

The type-punning is technically undefined behaviour, but works in
practice.  Clean up: drop the callback, and call qemu_printf()
instead.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Message-Id: <20190417191805.28198-11-armbru@redhat.com>
18 files changed:
target/m68k/cpu.h
target/m68k/helper.c
target/m68k/monitor.c
target/nios2/cpu.h
target/nios2/mmu.c
target/nios2/monitor.c
target/ppc/cpu.h
target/ppc/mmu-hash64.c
target/ppc/mmu-hash64.h
target/ppc/mmu_helper.c
target/ppc/monitor.c
target/sparc/cpu.h
target/sparc/ldst_helper.c
target/sparc/mmu_helper.c
target/sparc/monitor.c
target/xtensa/cpu.h
target/xtensa/mmu_helper.c
target/xtensa/monitor.c