libqos: add virtio used ring support
commite77abbe98b944990b3ab49c671ec15371904e206
authorStefan Hajnoczi <stefanha@redhat.com>
Wed, 28 Jun 2017 18:47:20 +0000 (28 19:47 +0100)
committerStefan Hajnoczi <stefanha@redhat.com>
Fri, 30 Jun 2017 10:03:45 +0000 (30 11:03 +0100)
tree477c69eb898acd1255c8a40b4db77bb321c6f823
parentafbccba608cec3e78c8eb31f6b7d2cd0c9908e05
libqos: add virtio used ring support

Existing tests do not touch the virtqueue used ring.  Instead they poll
the virtqueue ISR register and peek into their request's device-specific
status field.

It turns out that the virtqueue ISR register can be set to 1 more than
once for a single notification (see commit
83d768b5640946b7da55ce8335509df297e2c7cd "virtio: set ISR on dataplane
notifications").  This causes problems for tests that assume a 1:1
correspondence between the ISR being 1 and request completion.

Peeking at device-specific status fields is also problematic if the
device has no field that can be abused for EINPROGRESS polling
semantics.  This is the case if all the field's values may be set by the
device; there's no magic constant left for polling.

It's time to process the used ring for completed requests, just like a
real virtio guest driver.  This patch adds the necessary APIs.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Fam Zheng <famz@redhat.com>
Tested-by: Eric Blake <eblake@redhat.com>
Tested-by: Kevin Wolf <kwolf@redhat.com>
Message-id: 20170628184724.21378-3-stefanha@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
tests/libqos/virtio.c
tests/libqos/virtio.h