| commit | bdd8e6b5d8a9def83d491a3f41c10424fc366258 | |
| author | Eric Blake <eblake@redhat.com> | |
| Fri, 29 Jan 2016 13:48:58 +0000 (29 06:48 -0700) | ||
| committer | Markus Armbruster <armbru@redhat.com> | |
| Mon, 8 Feb 2016 16:29:57 +0000 (8 17:29 +0100) | ||
| tree | 5dbd184d2b8afebddee58a26f2b996f7cc95552c | treesnapshot (tar.gz zip) |
| parent | 337283dffbb5ad5860ed00408a5fd0665c21be07 | commitdiff |
qapi: Tighten qmp_input_end_list()
The only way that qmp_input_pop() will set errp is if a dictionary
was the most recent thing pushed. Since we don't have any
push(struct)/pop(list) or push(list)/pop(struct) mismatches (such
a mismatch is a programming bug), we therefore cannot set errp
inside qmp_input_end_list(). Make this obvious by
using &error_abort. A later patch will then remove the errp
parameter of qmp_input_pop(), but that will first require the
larger task of splitting visit_end_struct().
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <1454075341-13658-23-git-send-email-eblake@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
The only way that qmp_input_pop() will set errp is if a dictionary
was the most recent thing pushed. Since we don't have any
push(struct)/pop(list) or push(list)/pop(struct) mismatches (such
a mismatch is a programming bug), we therefore cannot set errp
inside qmp_input_end_list(). Make this obvious by
using &error_abort. A later patch will then remove the errp
parameter of qmp_input_pop(), but that will first require the
larger task of splitting visit_end_struct().
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <1454075341-13658-23-git-send-email-eblake@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
| qapi/qmp-input-visitor.c | diffblobblamehistory |