vfio/display: Fix error path in call site of ramfb_setup()
commit9442d8af674c80a2f8a7358977e1fc7ed43d2776
authorZhenzhong Duan <zhenzhong.duan@intel.com>
Wed, 22 May 2024 04:39:56 +0000 (22 12:39 +0800)
committerCédric Le Goater <clg@redhat.com>
Wed, 22 May 2024 08:04:21 +0000 (22 10:04 +0200)
treee0c9660e238aa3b4d88434694230f30a2e4d2f65
parent9067d50dff29b1b96ef0d4ab7448dbd7b636e55c
vfio/display: Fix error path in call site of ramfb_setup()

vfio_display_dmabuf_init() and vfio_display_region_init() calls
ramfb_setup() without checking its return value.

So we may run into a situation that vfio_display_probe() succeed
but errp is set. This is risky and may lead to assert failure in
error_setv().

Cc: Gerd Hoffmann <kraxel@redhat.com>
Fixes: b290659fc3d ("hw/vfio/display: add ramfb support")
Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Signed-off-by: Cédric Le Goater <clg@redhat.com>
hw/vfio/display.c