| commit | 645acdc0e66277712c7af8a7d8de6a62dc5eb48a | |
| author | Max Reitz <mreitz@redhat.com> | |
| Tue, 25 Jul 2017 15:56:43 +0000 (25 17:56 +0200) | ||
| committer | Kevin Wolf <kwolf@redhat.com> | |
| Tue, 1 Aug 2017 16:09:33 +0000 (1 18:09 +0200) | ||
| tree | 949fdd92dc509e1cb0127a55024a84814e59e193 | treesnapshot (tar.gz zip) |
| parent | 5619c179057e24195ff19c8fe6d6a6cbcb16ed28 | commitdiff |
iotests: Fix test 156
On one hand, the _make_test_img invocation for creating the target image
was missing a -u because its backing file is not supposed to exist at
that point.
On the other hand, nobody noticed probably because the backing file is
created later on and _cleanup failed to remove it: The quotation marks
were misplaced so bash tried to delete a file literally called
"$TEST_IMG{,.target}..." instead of performing brace expansion. Thus, the
files stayed around after the first run and qemu-img create did not
complain about a missing backing file on any run but the first.
Signed-off-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Jeff Cody <jcody@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
On one hand, the _make_test_img invocation for creating the target image
was missing a -u because its backing file is not supposed to exist at
that point.
On the other hand, nobody noticed probably because the backing file is
created later on and _cleanup failed to remove it: The quotation marks
were misplaced so bash tried to delete a file literally called
"$TEST_IMG{,.target}..." instead of performing brace expansion. Thus, the
files stayed around after the first run and qemu-img create did not
complain about a missing backing file on any run but the first.
Signed-off-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Jeff Cody <jcody@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
| tests/qemu-iotests/156 | diffblobblamehistory |