tests/qapi-schema: Tidy up pylint warnings and advicepull-qapi-2023-11-13
commit5c24c3e2f3b22f1b77d556a14dd3bb8deed1f976
authorMarkus Armbruster <armbru@redhat.com>
Wed, 25 Oct 2023 09:29:25 +0000 (25 11:29 +0200)
committerMarkus Armbruster <armbru@redhat.com>
Mon, 13 Nov 2023 09:36:51 +0000 (13 10:36 +0100)
tree8d017c55a1add648bf3d09fe9fe0653a769a5c17
parentc375f05ef5a358f1dd19b45bb348100de0f97c9d
tests/qapi-schema: Tidy up pylint warnings and advice

Pylint warns:

    tests/qapi-schema/test-qapi.py:139:13: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
    tests/qapi-schema/test-qapi.py:143:13: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)

Add encoding='utf-8'.

Pylint advises:

    tests/qapi-schema/test-qapi.py:143:13: R1732: Consider using 'with' for resource-allocating operations (consider-using-with)

Silence this by returning the value directly.

Pylint advises:

    tests/qapi-schema/test-qapi.py:221:4: R1722: Consider using sys.exit() (consider-using-sys-exit)
    tests/qapi-schema/test-qapi.py:226:4: R1722: Consider using sys.exit() (consider-using-sys-exit)

Sure, why not.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-ID: <20231025092925.1785934-1-armbru@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
tests/qapi-schema/test-qapi.py