| commit | 3d508334dd2c5f920a1b5221124b6633c3bf8e38 | |
| author | Markus Armbruster <armbru@redhat.com> | |
| Wed, 4 Dec 2019 09:36:18 +0000 (4 10:36 +0100) | ||
| committer | Cornelia Huck <cohuck@redhat.com> | |
| Sat, 14 Dec 2019 09:25:50 +0000 (14 10:25 +0100) | ||
| tree | 4f9e9207151b0ddfe075076841b0f775ee101739 | treesnapshot (tar.gz zip) |
| parent | e893baee70149896d1e43e341da4d6c614037d5d | commitdiff |
s390x/event-facility: Fix realize() error API violations
sclp_events_bus_realize() dereferences @errp when
object_property_set_bool() fails. That's wrong; see the big comment
in error.h. Introduced in commit f6102c329c "s390/sclp: rework sclp
event facility initialization + device realization".
No caller actually passes null.
Fix anyway: splice in a local Error *err, and error_propagate().
Cc: David Hildenbrand <david@redhat.com>
Cc: Cornelia Huck <cohuck@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Message-Id: <20191204093625.14836-12-armbru@redhat.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
sclp_events_bus_realize() dereferences @errp when
object_property_set_bool() fails. That's wrong; see the big comment
in error.h. Introduced in commit f6102c329c "s390/sclp: rework sclp
event facility initialization + device realization".
No caller actually passes null.
Fix anyway: splice in a local Error *err, and error_propagate().
Cc: David Hildenbrand <david@redhat.com>
Cc: Cornelia Huck <cohuck@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Message-Id: <20191204093625.14836-12-armbru@redhat.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
| hw/s390x/event-facility.c | diffblobblamehistory |