| commit | 3b4790d4ec1f01a1d0575bda23aa08a2061d601c | |
| author | Eric Blake <eblake@redhat.com> | |
| Fri, 12 May 2023 02:10:16 +0000 (11 21:10 -0500) | ||
| committer | Eric Blake <eblake@redhat.com> | |
| Fri, 2 Jun 2023 16:24:18 +0000 (2 11:24 -0500) | ||
| tree | f14191ccb3b71aa3300ad52cf757bb023f51b048 | treesnapshot (tar.gz zip) |
| parent | 3a5925922520f934f7b0f96d0c65a041540d7738 | commitdiff |
test-cutils: Use g_assert_cmpuint where appropriate
When debugging test failures, seeing unsigned values as large positive
values rather than negative values matters (assuming glib 2.78+; given
that I just fixed a bug in glib 2.76 [1] where g_assert_cmpuint
displays signed instead of unsigned values). No impact when the test
is passing, but using a consistent style will matter more in upcoming
test additions. Also, some tests are better with cmphex.
While at it, fix some spacing and minor typing issues spotted nearby.
[1] https://gitlab.gnome.org/GNOME/glib/-/issues/2997
Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Hanna Czenczek <hreitz@redhat.com>
Message-Id: <20230522190441.64278-3-eblake@redhat.com>
When debugging test failures, seeing unsigned values as large positive
values rather than negative values matters (assuming glib 2.78+; given
that I just fixed a bug in glib 2.76 [1] where g_assert_cmpuint
displays signed instead of unsigned values). No impact when the test
is passing, but using a consistent style will matter more in upcoming
test additions. Also, some tests are better with cmphex.
While at it, fix some spacing and minor typing issues spotted nearby.
[1] https://gitlab.gnome.org/GNOME/glib/-/issues/2997
Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Hanna Czenczek <hreitz@redhat.com>
Message-Id: <20230522190441.64278-3-eblake@redhat.com>
| tests/unit/test-cutils.c | diffblobblamehistory |