| commit | 19109131ca2701de1b4e083bd51172f376f7a5ef | |
| author | Markus Armbruster <armbru@redhat.com> | |
| Mon, 23 Mar 2015 18:22:10 +0000 (23 19:22 +0100) | ||
| committer | Markus Armbruster <armbru@redhat.com> | |
| Thu, 2 Apr 2015 13:30:39 +0000 (2 15:30 +0200) | ||
| tree | 15de7615efdaab26c53964f4c63a7d348a203589 | treesnapshot (tar.gz zip) |
| parent | 19f33f16890fc5ec0d43841625ca44ef28767d1a | commitdiff |
sdhci: Make device "sdhci-pci" unavailable with -device
Device models aren't supposed to go on fishing expeditions for
backends. They should expose suitable properties for the user to set.
For onboard devices, board code sets them.
"sdhci-pci" picks up its block backend in its realize() method with
drive_get_next() instead. Already marked FIXME. See the commit that
added the FIXME for a more detailed explanation of what's wrong.
We can't fix this in time for the release, but since the device is new
in 2.3, we can set cannot_instantiate_with_device_add_yet to disable
it before this mistake becomes ABI, and we have to support command
lines like
$ qemu -drive if=sd -drive if=sd,file=sd.img -device sdhci-pci -device sdhci-pci
forever.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Device models aren't supposed to go on fishing expeditions for
backends. They should expose suitable properties for the user to set.
For onboard devices, board code sets them.
"sdhci-pci" picks up its block backend in its realize() method with
drive_get_next() instead. Already marked FIXME. See the commit that
added the FIXME for a more detailed explanation of what's wrong.
We can't fix this in time for the release, but since the device is new
in 2.3, we can set cannot_instantiate_with_device_add_yet to disable
it before this mistake becomes ABI, and we have to support command
lines like
$ qemu -drive if=sd -drive if=sd,file=sd.img -device sdhci-pci -device sdhci-pci
forever.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
| hw/sd/sdhci.c | diffblobblamehistory |