| commit | 010f5557ab1d5d14c3ffc023387289c68b889cc9 | |
| author | Alistair Francis <alistair23@gmail.com> | |
| Mon, 25 Sep 2023 04:30:20 +0000 (25 14:30 +1000) | ||
| committer | Markus Armbruster <armbru@redhat.com> | |
| Fri, 29 Sep 2023 08:07:20 +0000 (29 10:07 +0200) | ||
| tree | 518b0277de39fe4dd364a0a82b7b0688a5855349 | treesnapshot (tar.gz zip) |
| parent | e161785c05c8a96962a0ea87a3abefe158d8b035 | commitdiff |
hw/riscv: opentitan: Fixup local variables shadowing
Local variables shadowing other local variables or parameters make the
code needlessly hard to understand. Bugs love to hide in such code.
Evidence: "[PATCH v3 1/7] migration/rdma: Fix save_page method to fail
on polling error".
This patch removes the local variable shadowing. Tested by adding:
--extra-cflags='-Wshadow=local -Wno-error=shadow=local -Wno-error=shadow=compatible-local'
To configure
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
Message-ID: <20230925043023.71448-2-alistair.francis@wdc.com>
Reviewed-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Local variables shadowing other local variables or parameters make the
code needlessly hard to understand. Bugs love to hide in such code.
Evidence: "[PATCH v3 1/7] migration/rdma: Fix save_page method to fail
on polling error".
This patch removes the local variable shadowing. Tested by adding:
--extra-cflags='-Wshadow=local -Wno-error=shadow=local -Wno-error=shadow=compatible-local'
To configure
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
Message-ID: <20230925043023.71448-2-alistair.francis@wdc.com>
Reviewed-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
| hw/riscv/opentitan.c | diffblobblamehistory |