From acdc3f0c59d076099c63425158c4811aaee984b6 Mon Sep 17 00:00:00 2001 From: Juan Quintela Date: Wed, 20 Jan 2010 00:56:21 +0100 Subject: [PATCH] check pipe() return value Signed-off-by: Juan Quintela Signed-off-by: Anthony Liguori --- hw/xen_domainbuild.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/hw/xen_domainbuild.c b/hw/xen_domainbuild.c index 20d731ded4..2f59856f73 100644 --- a/hw/xen_domainbuild.c +++ b/hw/xen_domainbuild.c @@ -156,15 +156,18 @@ quit: return; } -static void xen_domain_watcher(void) +static int xen_domain_watcher(void) { int qemu_running = 1; int fd[2], i, n, rc; char byte; - pipe(fd); + if (pipe(fd) != 0) { + qemu_log("%s: Huh? pipe error: %s\n", __FUNCTION__, strerror(errno)); + return -1; + } if (fork() != 0) - return; /* not child */ + return 0; /* not child */ /* close all file handles, except stdio/out/err, * our watch pipe and the xen interface handle */ @@ -238,7 +241,9 @@ int xen_domain_build_pv(const char *kernel, const char *ramdisk, } qemu_log("xen: created domain %d\n", xen_domid); atexit(xen_domain_cleanup); - xen_domain_watcher(); + if (xen_domain_watcher() == -1) { + goto err; + } xenstore_domain_init1(kernel, ramdisk, cmdline); -- 2.11.4.GIT