From 5351e69af826665cef6858c960c3336a4228bb70 Mon Sep 17 00:00:00 2001 From: Wei Yang Date: Wed, 24 Apr 2019 08:46:57 +0800 Subject: [PATCH] migration/savevm: remove duplicate check of migration_is_blocked Current call flow of save_snapshot is: save_snapshot migration_is_blocked qemu_savevm_state migration_is_blocked Since qemu_savevm_state is only called in save_snapshot, this means migration_is_blocked has been already checked. Signed-off-by: Wei Yang Message-Id: <20190424004700.12766-2-richardw.yang@linux.intel.com> Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Dr. David Alan Gilbert --- migration/savevm.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/migration/savevm.c b/migration/savevm.c index 81a9a2ef30..6e8912af49 100644 --- a/migration/savevm.c +++ b/migration/savevm.c @@ -1418,10 +1418,6 @@ static int qemu_savevm_state(QEMUFile *f, Error **errp) return -EINVAL; } - if (migration_is_blocked(errp)) { - return -EINVAL; - } - if (migrate_use_block()) { error_setg(errp, "Block migration and snapshots are incompatible"); return -EINVAL; -- 2.11.4.GIT