From 3fa123d05964b07f9d4d972f131cce847091926d Mon Sep 17 00:00:00 2001 From: Alberto Garcia Date: Tue, 3 Nov 2015 12:32:37 +0200 Subject: [PATCH] block: test 'blockdev-snapshot' using a file BDS as the overlay This test checks that it is not possible to create a snapshot if the requested overlay node is a BDS which does not support backing images. Signed-off-by: Alberto Garcia Reviewed-by: Eric Blake Signed-off-by: Kevin Wolf --- tests/qemu-iotests/085 | 12 +++++++++++- tests/qemu-iotests/085.out | 4 ++++ 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/tests/qemu-iotests/085 b/tests/qemu-iotests/085 index 80e547d81b..aa77eca77d 100755 --- a/tests/qemu-iotests/085 +++ b/tests/qemu-iotests/085 @@ -103,7 +103,8 @@ function add_snapshot_image() { 'options': { 'driver': 'qcow2', 'node-name': 'snap_${1}', ${extra_params} 'file': - { 'driver': 'file', 'filename': '${snapshot_file}' } } } }" + { 'driver': 'file', 'filename': '${snapshot_file}', + 'node-name': 'file_${1}' } } } }" _send_qemu_cmd $h "${cmd}" "return" } @@ -187,6 +188,15 @@ add_snapshot_image ${SNAPSHOTS} blockdev_snapshot ${SNAPSHOTS} echo +echo === Invalid command - cannot create a snapshot using a file BDS === +echo + +_send_qemu_cmd $h "{ 'execute': 'blockdev-snapshot', + 'arguments': { 'node':'virtio0', + 'overlay':'file_${SNAPSHOTS}' } + }" "error" + +echo echo === Invalid command - snapshot node used as active layer === echo diff --git a/tests/qemu-iotests/085.out b/tests/qemu-iotests/085.out index 52292eac4e..01c78d6894 100644 --- a/tests/qemu-iotests/085.out +++ b/tests/qemu-iotests/085.out @@ -62,6 +62,10 @@ Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=134217728 backing_file=TEST_DIR/ {"return": {}} {"return": {}} +=== Invalid command - cannot create a snapshot using a file BDS === + +{"error": {"class": "GenericError", "desc": "The snapshot does not support backing images"}} + === Invalid command - snapshot node used as active layer === {"error": {"class": "GenericError", "desc": "The snapshot is already in use by virtio0"}} -- 2.11.4.GIT