From 0d84f47bff2f98d0cea5fb27e9b62225ccebd70a Mon Sep 17 00:00:00 2001 From: Eric Auger Date: Mon, 17 Oct 2016 10:58:00 -0600 Subject: [PATCH] vfio/platform: fix a wrong returned value in vfio_populate_device In case the vfio_init_intp fails we currently do not return an error value. This patch fixes the bug. The returned value is not explicit but in practice the error object is the one used to report the error to the end-user and the actual returned error value is not used. Signed-off-by: Eric Auger Reviewed-by: Markus Armbruster Signed-off-by: Alex Williamson --- hw/vfio/platform.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/vfio/platform.c b/hw/vfio/platform.c index 1a35da04c3..484e31f233 100644 --- a/hw/vfio/platform.c +++ b/hw/vfio/platform.c @@ -508,6 +508,7 @@ static int vfio_populate_device(VFIODevice *vbasedev, Error **errp) irq.flags); intp = vfio_init_intp(vbasedev, irq, errp); if (!intp) { + ret = -1; goto irq_err; } } -- 2.11.4.GIT