From 0a2ebce92a3f10a89843e4a7a8e2f2eba4f7b109 Mon Sep 17 00:00:00 2001 From: Thomas Huth Date: Fri, 11 Dec 2020 16:24:26 +0100 Subject: [PATCH] configure: Compile with -Wimplicit-fallthrough=2 Coverity always complains about switch-case statements that fall through the next one when there is no comment in between - which could indicate a forgotten "break" statement. Instead of handling these issues after they have been committed, it would be better to avoid them in the build process already. Thus let's enable the -Wimplicit-fallthrough warning now. The "=2" level seems to be a good compromise between being too strict and too generic about the possible comments, so we'll start with "=2" for now. Signed-off-by: Thomas Huth Reviewed-by: Chen Qun Reviewed-by: Peter Maydell Message-Id: <20201211152426.350966-13-thuth@redhat.com> Signed-off-by: Thomas Huth --- configure | 1 + 1 file changed, 1 insertion(+) diff --git a/configure b/configure index c228f7c21e..881af4b6be 100755 --- a/configure +++ b/configure @@ -2023,6 +2023,7 @@ add_to warn_flags -Wempty-body add_to warn_flags -Wnested-externs add_to warn_flags -Wendif-labels add_to warn_flags -Wexpansion-to-defined +add_to warn_flags -Wimplicit-fallthrough=2 nowarn_flags= add_to nowarn_flags -Wno-initializer-overrides -- 2.11.4.GIT